fix(AvatarStack): change ordering algorithm for correct logical order li #2480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Contributor
|
Preview is ready. |
Contributor
|
Visual Tests Report is ready. |
Contributor
Author
|
@ogonkov |
ogonkov
reviewed
Nov 14, 2025
| border-radius: 100%; | ||
|
|
||
| &:not(:first-child) { | ||
| &:not(:last-child) { |
Contributor
There was a problem hiding this comment.
looks like some mistyping, can you return empty line here please?
Contributor
Author
There was a problem hiding this comment.
This selector is necessary for determining the correct size of the container.
With &:not..
Without &:not..
| {visibleItems} | ||
| {hasMoreButton ? ( | ||
| <AvatarStackItem key="more-button"> | ||
| <AvatarStackItem key="more-button" style={{zIndex: 0}}> |
Contributor
There was a problem hiding this comment.
Move this object to some variable outside of component please, to avoid redundant props change
Comment on lines
7
to
9
| type Props = React.PropsWithChildren<{ | ||
| style?: React.CSSProperties; | ||
| }>; |
Contributor
There was a problem hiding this comment.
Suggested change
| type Props = React.PropsWithChildren<{ | |
| style?: React.CSSProperties; | |
| }>; | |
| type Props = React.PropsWithChildren<Pick<HTMLLIElement, 'style'>>; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.